avantgardnerio opened a new pull request, #18029: URL: https://github.com/apache/datafusion/pull/18029
## Which issue does this PR close? - Closes #18028. ## Rationale for this change It's pretty important optimizer rules don't change results. ## What changes are included in this PR? 1. A new `LimitEffect` similar to `CardinalityEffect` with which plan nodes and window functions can declare their effects on limit_pushdown 2. Most functions are None or Unknown, but the options is given to `Lead()` and `NthValue` to calculate and return their effect 3. Updates to the optimizer rule to take these into account, as well as partitioning 4. Tests for all of the above ## Are these changes tested? In a new `window_limits.slt` to break things up. ## Are there any user-facing changes? Yes, we should patch-fix and notify users. Credit to @Dandandan for finding this bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
