alamb commented on code in PR #17819:
URL: https://github.com/apache/datafusion/pull/17819#discussion_r2392483962


##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1201,6 +1201,7 @@ impl TableProvider for ListingTable {
         // If the filters can be resolved using only partition cols, there is 
no need to
         // pushdown it to TableScan, otherwise, `unhandled` pruning predicates 
will be generated
         let (partition_filters, filters): (Vec<_>, Vec<_>) =
+            // TODO avoid .cloned() here by accepting &[&Expr] or equivalent 
downstream

Review Comment:
   no, that is fine, I was just confused



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to