findepi commented on code in PR #17819:
URL: https://github.com/apache/datafusion/pull/17819#discussion_r2387074382
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -563,10 +565,10 @@ fn push_down_join(
/// * `on_filters` filters from the join ON clause that have not already been
/// identified as join predicates
///
-fn infer_join_predicates(
+fn infer_join_predicates<E: AsRef<Expr>>(
join: &Join,
- predicates: &[Expr],
- on_filters: &[Expr],
+ predicates: &[E],
Review Comment:
This can also be written as `impl IntoIterator<Item = &'a Expr>`
but this is much less flexible. It allows only iteration and only once.
Slice can be passed to multiple such functions, iterated over or
random-accessed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
