dqkqd commented on code in PR #17921:
URL: https://github.com/apache/datafusion/pull/17921#discussion_r2404689267
##########
datafusion/core/src/datasource/file_format/arrow.rs:
##########
@@ -298,7 +300,7 @@ impl FileSink for ArrowFileSink {
demux_task
.join_unwind()
.await
- .map_err(|e| DataFusionError::ExecutionJoin(Box::new(e)))??;
+ .map_err(|e| exec_datafusion_err!("ExecutionJoin error: {}", e))??;
Review Comment:
I'm still quite new to the codebase, but I think using
`DataFusionError::Execution` here is not equivalent to
`DataFusionError::ExecutionJoin`.
There are other places we used `exec_datafusion_err!` for `ExecutionJoin` as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
