dqkqd commented on code in PR #17921:
URL: https://github.com/apache/datafusion/pull/17921#discussion_r2404659014
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1196,9 +1184,11 @@ impl SessionContext {
match function_factory {
Some(f) => f.create(&state, stmt).await?,
- _ => Err(DataFusionError::Configuration(
- "Function factory has not been configured".into(),
- ))?,
+ _ => {
+ return Err(DataFusionError::Configuration(
+ "Function factory has not been configured".to_string(),
+ ))
+ }
Review Comment:
I think we can use `config_err!` here.
```suggestion
_ => {
return config_err!("Function factory has not been
configured")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
