adriangb commented on code in PR #18192:
URL: https://github.com/apache/datafusion/pull/18192#discussion_r2448132611


##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -865,6 +865,10 @@ message PhysicalExprNode {
 
     UnknownColumn unknown_column = 20;
   }
+
+  // Optional ID for caching during deserialization.
+  // Set to the Arc pointer address during serialization to enable 
deduplication.

Review Comment:
   What this accomplishes is that if you deserialize both a `DataSourceExec` 
and `TopK` execution node on the same machine at least those two are connected.
   
   Connecting them *between* machines needs more work, e.g. 
https://github.com/apache/datafusion/pull/18192#discussion_r2448127711



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to