gabotechs commented on code in PR #18192:
URL: https://github.com/apache/datafusion/pull/18192#discussion_r2448447879
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -865,6 +865,10 @@ message PhysicalExprNode {
UnknownColumn unknown_column = 20;
}
+
+ // Optional ID for caching during deserialization.
+ // Set to the Arc pointer address during serialization to enable
deduplication.
Review Comment:
Makes sense. Still feels a bit weird to use a pointer address as identifier
where in most cases serialization/deserialization will happen in different
machines, but I have to agree it gets the job done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
