Jefffrey commented on code in PR #18192:
URL: https://github.com/apache/datafusion/pull/18192#discussion_r2450132472
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -865,6 +865,10 @@ message PhysicalExprNode {
UnknownColumn unknown_column = 20;
}
+
+ // Optional ID for caching during deserialization.
+ // Set to the Arc pointer address during serialization to enable
deduplication.
Review Comment:
Maybe we can change the documentation to something like:
```
// Optional ID for caching during deserialization. This is used for
deduplication,
// so PhysicalExprs with the same ID will be deserialized as Arcs pointing
to the
// same address (instead of distinct addresses) on the deserializing
machine.
//
// We use the Arc pointer address during serialization as the ID, as this
by default
// indicates if a PhysicalExpr is identical to another on the serializing
machine.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
