ByteBaker opened a new pull request, #18252: URL: https://github.com/apache/datafusion/pull/18252
## Which issue does this PR close? Closes #13037 ## Rationale for this change DataFusion previously maintained custom implementations of `record_batch!` and `create_array!` macros. These macros are now available upstream in arrow-rs (added in https://github.com/apache/arrow-rs/pull/6588), so we should use those instead to reduce code duplication and align with the Arrow ecosystem. ## What changes are included in this PR? - Removed custom `record_batch!` and `create_array!` macro definitions from `datafusion/common/src/test_util.rs` - Re-exported the macros from `arrow::array` instead - Updated all 67 usages across 24 files from `vec![...]` syntax to array literal `[...]` syntax to match arrow-rs macro expectations - Added `arrow_schema` module aliases in test modules for macro compatibility - Replaced macro usage with manual `RecordBatch::try_new()` construction in cases where variables are passed (macros only support literal values) ## Are these changes tested? - All existing tests pass (no new test failures introduced) - Verified with `cargo test --lib` across all modified packages - `cargo clippy` and `cargo fmt` checks pass on modified code ## Are there any user-facing changes? No user-facing changes. The macros maintain the same public API, just sourced from arrow-rs instead of DataFusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
