adriangb commented on code in PR #18252:
URL: https://github.com/apache/datafusion/pull/18252#discussion_r2468017244
##########
datafusion/common/src/test_util.rs:
##########
@@ -318,63 +318,16 @@ pub fn get_data_dir(
}
}
+// Re-export arrow-rs macros for creating arrays and record batches
+// See https://github.com/apache/arrow-rs/pull/6588
+pub use arrow::array::{create_array, record_batch};
+
+/// Legacy record_batch_old! macro for cases where arrow-rs macro cannot be
used
Review Comment:
Do we really want to rename this and break all downstream users if there is
no alternative? I would keep this as is with the goal to eventually replace it
with a re-export and a note and only then remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
