rluvaton commented on PR #18152: URL: https://github.com/apache/datafusion/pull/18152#issuecomment-3452403552
> > Looks pretty good to me, left some comments, once resolved I can approve > > I think I got 'em all except for the `break` suggestion. I would prefer to leave that as is so all the early exits follow the same and we don't need any special safety checks or assertions after the when/then loop. The duplicated calls to `finish` aren't ideal, but I feel this is better than the alternative. fine by me > > I don't think you need generics here, you can have a trait for the logic and require implementation on the few differences (like evaluating the when) > > I think I'm going to leave this for a followup PR. There are some subtle differences wrt an owned `when` array vs a reference that make this a bit tricky. Template method is nice in theory, but it also makes the code a bit harder to read since you need to jump back and forth between locations in the source file. Perhaps this is a case where it's better to not be ultra DRY? np -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
