pepijnve commented on PR #18152: URL: https://github.com/apache/datafusion/pull/18152#issuecomment-3452434003
> > I think I'm going to leave this for a followup PR. There are some subtle differences wrt an owned when array vs a reference that make this a bit tricky. Template method is nice in theory, but it also makes the code a bit harder to read since you need to jump back and forth between locations in the source file. Perhaps this is a case where it's better to not be ultra DRY? > > np Just for kicks I've asked Claude code to give it a try. You never know... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
