EmilyMatt opened a new pull request, #18325:
URL: https://github.com/apache/datafusion/pull/18325
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #18323 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Adds more detailed metrics, so it is easier to identify which part of the
aggregate streams are actually slow.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Added a metrics struct, and used it in the functions common to the
aggregate streams.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes, added some tests to verify the metrics are actually updated and can be
retrieved.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Yes, the evaluate_many function was renamed, as well as made pub(crate)
instead of pub, I believe this function was only meant to be a util function
within the aggregates module, but instead, it was set to pub, which is a bad
idea bc it could cause users to use it without knowing its purpose and that it
may change(like in this case) based on the aggregate needs.
I think such a function (which literally just takes a slice of physicalexprs
and a batch, and returns the result of evaluating all those exprs with that
input batch) should be in a utils file somewhere in the datafusion common
crate, not in such a specific module.
So I've renamed this function, and passed to it a reference to our metrics
struct, which will simply create a timer and measure how long it took to
evaluate these input arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
