rluvaton commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469810561
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -845,6 +859,7 @@ impl GroupedHashAggregateStream {
evaluate_optional(&self.filter_expressions, &batch)?
};
+ let aggregation_timer = self.group_by_metrics.aggregation_time.timer();
Review Comment:
Observation: the aggregation time also include finding the group indices
which I don't think it
however a possible solution is to move inside the loop but I'm not a fan of
it as it can be a hot loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
