alamb commented on code in PR #18322:
URL: https://github.com/apache/datafusion/pull/18322#discussion_r2475313414
##########
datafusion/spark/src/function/bitwise/bit_count.rs:
##########
@@ -90,28 +90,28 @@ impl ScalarUDFImpl for SparkBitCount {
fn spark_bit_count(value_array: &[ArrayRef]) -> Result<ArrayRef> {
let value_array = value_array[0].as_ref();
match value_array.data_type() {
- DataType::Int8 => {
+ DataType::Int8 | DataType::Boolean => {
Review Comment:
I also think this code will now panic if you pass in a Boolean array
##########
datafusion/spark/src/function/bitwise/bit_count.rs:
##########
@@ -90,28 +90,28 @@ impl ScalarUDFImpl for SparkBitCount {
fn spark_bit_count(value_array: &[ArrayRef]) -> Result<ArrayRef> {
let value_array = value_array[0].as_ref();
match value_array.data_type() {
- DataType::Int8 => {
+ DataType::Int8 | DataType::Boolean => {
Review Comment:
This comment seems misplaced as the code adds support for boolean 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
