Jefffrey commented on code in PR #18322:
URL: https://github.com/apache/datafusion/pull/18322#discussion_r2476637400
##########
datafusion/spark/src/function/bitwise/bit_count.rs:
##########
@@ -147,6 +147,18 @@ fn spark_bit_count(value_array: &[ArrayRef]) ->
Result<ArrayRef> {
}
}
+// Here’s the equivalent Rust implementation of the bitCount function (similar
to Apache Spark's bitCount for LongType)
+fn bit_count(i: i64) -> i32 {
Review Comment:
Could we enhance the comment here with this link + potentially link to
original source code this actual function is copied from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
