CuteChuanChuan commented on code in PR #1337:
URL:
https://github.com/apache/datafusion-ballista/pull/1337#discussion_r2478503004
##########
ballista/core/src/utils.rs:
##########
@@ -36,6 +37,64 @@ use std::{fs::File, pin::Pin};
use tonic::codegen::StdError;
use tonic::transport::{Channel, Error, Server};
+#[derive(Debug, Clone)]
+pub struct GrpcClientConfig {
+ pub connect_timeout_seconds: u64,
+ pub timeout_seconds: u64,
+ pub tcp_keepalive_seconds: u64,
+ pub http2_keepalive_interval_seconds: u64,
+ pub keepalive_timeout_seconds: u64,
+}
+
+impl GrpcClientConfig {
+ pub fn from_ballista_config(config: &BallistaConfig) -> Self {
Review Comment:
Considering that GrpcClientConfig is derived by extracting specific configs
from BallistaConfig, I think `From` is more appropriate than `Into` here. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
