CuteChuanChuan commented on code in PR #1337:
URL:
https://github.com/apache/datafusion-ballista/pull/1337#discussion_r2481768275
##########
ballista/executor/src/executor_process.rs:
##########
@@ -245,8 +249,11 @@ pub async fn start_executor_process(
));
let connect_timeout = opt.scheduler_connect_timeout_seconds as u64;
+ let session_config = (executor.config_producer)();
+ let ballista_config = session_config.ballista_config();
+ let grpc_client_config = GrpcClientConfig::from(&ballista_config);
let connection = if connect_timeout == 0 {
- create_grpc_client_connection(scheduler_url)
+ create_grpc_client_connection(scheduler_url, &grpc_client_config)
Review Comment:
Hi @milenkovicm ,
Good catch! However, since the `From` trait is implemented for
`&BallistaConfig` (not `BallistaConfig`), I need `&(&ballista_config).into()`
instead of `&ballista_config.into()`.
Would you prefer I change the implementation to `impl From<BallistaConfig>`
so we can use the simpler `&ballista_config.into()` syntax?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
