andygrove commented on code in PR #2634:
URL: https://github.com/apache/datafusion-comet/pull/2634#discussion_r2479269700
##########
spark/src/main/scala/org/apache/comet/serde/datetime.scala:
##########
@@ -256,6 +259,24 @@ object CometDateAdd extends
CometScalarFunction[DateAdd]("date_add")
object CometDateSub extends CometScalarFunction[DateSub]("date_sub")
object CometTruncDate extends CometExpressionSerde[TruncDate] {
+
+ val supportedFormats: Seq[String] =
+ Seq("year", "yyyy", "yy", "quarter", "mon", "month", "mm", "week")
Review Comment:
This is very confusing in Spark, but `date_trunc` is actually
`TruncTimestamp` and not `TruncDate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
