andygrove commented on PR #2634: URL: https://github.com/apache/datafusion-comet/pull/2634#issuecomment-3470196715
> Thanks @andygrove lgtm Btw when reviewing the code I found custom DateTrunc impl in Comet which probably not in use anymore `spark-expr/src/datetime_funcs/date_trunc.rs` > > If it is I'll create a clean up PR I assumed that those were the implementations that we were using, but I could be mistaken -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
