2010YOUY01 commented on code in PR #18408: URL: https://github.com/apache/datafusion/pull/18408#discussion_r2490029199
########## datafusion/sqllogictest/test_files/set_variable.slt: ########## @@ -244,3 +244,105 @@ SET TIME ZONE = 'Asia/Taipei2' statement error Arrow error: Parser error: Invalid timezone "Asia/Taipei2": failed to parse timezone SELECT '2000-01-01T00:00:00'::TIMESTAMP::TIMESTAMPTZ + Review Comment: Can we add some test coverage for invalid `reset`s like `reset dataexplosion.execution.batch_size`, `reset datafusion.exec.batch_size`, `reset datafusion.execution.batches_size` and `datafusion.execution.batch_size.bar` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
