Omega359 commented on code in PR #18408:
URL: https://github.com/apache/datafusion/pull/18408#discussion_r2508174590
##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1101,7 +1110,36 @@ impl SessionContext {
drop(state);
}
- self.return_empty_dataframe()
+ Ok(())
+ }
+
+ async fn reset_variable(&self, stmt: ResetVariable) -> Result<()> {
+ let variable = stmt.variable;
+ if variable.starts_with("datafusion.runtime.") {
+ return self.reset_runtime_variable(&variable);
+ }
+
+ let mut state = self.state.write();
+ state.config_mut().options_mut().reset(&variable)?;
+
+ // Refresh UDFs to ensure configuration-dependent behavior updates
+ let config_options = state.config().options();
+ let udfs_to_update: Vec<_> = state
+ .scalar_functions()
+ .values()
+ .filter_map(|udf| {
+ udf.inner()
+ .with_updated_config(config_options)
+ .map(Arc::new)
+ })
+ .collect();
+
+ for udf in udfs_to_update {
+ state.register_udf(udf)?;
+ }
+
+ drop(state);
Review Comment:
Why are you explicitly dropping state here? I can see no reason to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
