andygrove commented on issue #2633: URL: https://github.com/apache/datafusion-comet/issues/2633#issuecomment-3497347009
> These unit tests seem to indicate otherwise - > > [datafusion-comet/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala](https://github.com/apache/datafusion-comet/blob/3ad22eb865bbc990b0d9d103833c33f13a7af829/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L688) > > Line 688 in [3ad22eb](/apache/datafusion-comet/commit/3ad22eb865bbc990b0d9d103833c33f13a7af829) > test("date_trunc") { > > [datafusion-comet/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala](https://github.com/apache/datafusion-comet/blob/3ad22eb865bbc990b0d9d103833c33f13a7af829/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L671) > > Line 671 in [3ad22eb](/apache/datafusion-comet/commit/3ad22eb865bbc990b0d9d103833c33f13a7af829) > test("trunc with format array") { > > We should fix this rather than fall back. @parthchandra The tests that you linked to only test for valid formats. We did not have any tests for invalid or unsupported formats. This issue demonstrates testing `trunc` with `day` format, which Spark does not support (`day` is supported by `date_trunc` though). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
