parthchandra commented on issue #2633: URL: https://github.com/apache/datafusion-comet/issues/2633#issuecomment-3498547266
> > We should fix this rather than fall back. > > [@parthchandra](https://github.com/parthchandra) The tests that you linked to only test for valid formats. We did not have any tests for invalid or unsupported formats. This issue demonstrates testing `trunc` with `day` format, which Spark does not support (`day` is supported by `date_trunc` though). My point remains. Handling the unsupported formats can be added and, imho, preferable to falling back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
