Gohlub opened a new pull request, #18532:
URL: https://github.com/apache/datafusion/pull/18532
## Which issue does this PR close?
- Closes #18504.
## Rationale for this change
Followed suggestions to not update any public-facing APIs and put the lint
rule in the appropriate spot.
## What changes are included in this PR?
* Add #![deny(clippy::needless_pass_by_value)] and #![cfg_attr(test,
allow(clippy::needless_pass_by_value))] to lib.rs
* Add #[allow(clippy::needless_pass_by_value)] to public functions
* fix `rewrite_in_terms_of_projection()` and `get_exprs_except_skipped()`
to use references per the lint suggestion
## Are these changes tested?
Yes, though the same test failed even without changes to the public APIs:
`test expr_rewriter::order_by::test::rewrite_sort_cols_by_agg_alias ...
FAILED`
I'll append the logs for your convenience:
```
failures:
---- expr_rewriter::order_by::test::rewrite_sort_cols_by_agg_alias stdout
----
running: 'c1 --> c1 -- column *named* c1 that came out of the projection,
(not t.c1)'
running: 'min(c2) --> "min(c2)" -- (column *named* "min(t.c2)"!)'
thread 'expr_rewriter::order_by::test::rewrite_sort_cols_by_agg_alias'
(27524241) panicked at datafusion/expr/src/expr_rewriter/order_by.rs:308:13:
assertion `left == right` failed:
input:Sort { expr: AggregateFunction(AggregateFunction { func: AggregateUDF
{ inner: Min { name: "min", signature: Signature { type_signature: VariadicAny,
volatility: Immutable, parameter_names: None } } }, params:
AggregateFunctionParams { args: [Column(Column { relation: None, name: "c2"
})], distinct: false, filter: None, order_by: [], null_treatment: None } }),
asc: true, nulls_first: true }
rewritten:Sort { expr: Column(Column { relation: None, name: "min(t.c2)" }),
asc: true, nulls_first: true }
expected:Sort { expr: Column(Column { relation: Some(Bare { table: "min(t"
}), name: "c2)" }), asc: true, nulls_first: true }
left: Sort { expr: Column(Column { relation: None, name: "min(t.c2)" }),
asc: true, nulls_first: true }
right: Sort { expr: Column(Column { relation: Some(Bare { table: "min(t"
}), name: "c2)" }), asc: true, nulls_first: true }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
expr_rewriter::order_by::test::rewrite_sort_cols_by_agg_alias
```
## Are there any user-facing changes?
No, all modification were constrained to internal APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
