coderfender commented on code in PR #2600:
URL: https://github.com/apache/datafusion-comet/pull/2600#discussion_r2511667913
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -414,7 +416,7 @@ object QueryPlanSerde extends Logging with CometExprShim {
}
case s: Sum =>
if (AggSerde.sumDataTypeSupported(s.dataType) && !s.dataType
- .isInstanceOf[DecimalType]) {
+ .isInstanceOf[DecimalType] &&
!integerTypes.contains(s.dataType)) {
Review Comment:
Good question. The reason is the same as the special implementation as
@sunchao for Decimal addition (SumDecimal implementation) . If we truly want a
nartive window expression, we might want to implement sliding window
accumulator (in
[df](https://docs.rs/datafusion-functions-aggregate/latest/src/datafusion_functions_aggregate/sum.rs.html))
. I plan to support native sliding windows for both sum decimal and sum int
functions in subsequent PRs (once I finish ANSI support for avg function)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
