andygrove commented on code in PR #2600:
URL: https://github.com/apache/datafusion-comet/pull/2600#discussion_r2546645885
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -55,6 +55,8 @@ import org.apache.comet.shims.CometExprShim
*/
object QueryPlanSerde extends Logging with CometExprShim {
+ private val integerTypes = Seq(ByteType, ShortType, IntegerType, LongType)
Review Comment:
Perhaps it would be better to add an `isIntegerType` method to `object
DataTypeSupport`, or add something in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
