Jefffrey commented on issue #17964: URL: https://github.com/apache/datafusion/issues/17964#issuecomment-3517447988
> Regarding make_array, I'd need to look into `type_union_resolution` and `comparison_coersion` to understand what they do first. I'll try find some time to do so. These seem to do different things, but I played around with make_array (DF version) and spark_array a bit; putting the `coerce_types` logic of make_array into spark_array, it seems the tests all pass 🤔 I'm personally of the mind to do away to spark_array as much as we can (meaning use the make_array coerce logic) unless we can add a test case that proves their coercion logic differs in some way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
