Jefffrey commented on issue #17964: URL: https://github.com/apache/datafusion/issues/17964#issuecomment-3531242714
Regarding function names/aliases: The `spark_make_array` alias seems pretty odd given I don't believe spark names the array like that: https://github.com/apache/datafusion/blob/6685bbe5028609f676b27e435dbe095124fac99a/datafusion/spark/src/function/array/spark_array.rs#L57 So perhaps we can just remove it. We could then look into adding `array` as an alias for `make_array` (Datafusion version). I'm not familiar with how critical it is for the Spark version to have the field name, there was some discussion about that in the original PR it seems: https://github.com/apache/datafusion/pull/16936#discussion_r2237969612 Maybe for now we still leave them as separate functions (though I'm still in favour of removing the `spark_make_array` alias entirely) and just ensure they use the same internal code for doing the actual make array. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
