LucaCappelletti94 commented on code in PR #2094:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2094#discussion_r2517724380
##########
src/ast/ddl.rs:
##########
@@ -2002,22 +2002,45 @@ impl fmt::Display for DropBehavior {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
pub enum UserDefinedTypeRepresentation {
+ /// Composite type: `CREATE TYPE name AS (attributes)`
Composite {
attributes: Vec<UserDefinedTypeCompositeAttributeDef>,
},
+ /// Enum type: `CREATE TYPE name AS ENUM (labels)`
+ ///
/// Note: this is PostgreSQL-specific. See
<https://www.postgresql.org/docs/current/sql-createtype.html>
Enum { labels: Vec<Ident> },
+ /// Range type: `CREATE TYPE name AS RANGE (options)`
+ Range {
+ options: Vec<UserDefinedTypeRangeOption>,
+ },
+ /// Base type (SQL definition): `CREATE TYPE name (options)`
+ ///
+ /// Note the lack of `AS` keyword
+ SqlDefinition {
+ options: Vec<UserDefinedTypeSqlDefinitionOption>,
+ },
+ /// When the representation of the type is not specified.
+ /// This is used in `CREATE TYPE <name>;` statements.
+ None,
Review Comment:
Sure I can switch to that case - should we normalize other analogous
enumerations which also have the `None` field, maybe in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
