timsaucer commented on PR #18657: URL: https://github.com/apache/datafusion/pull/18657#issuecomment-3527823522
@martin-g Thank you for the review! Most of those are copy+paste things I didn't catch. I didn't change the recommendations where you were suggesting something that differs from the underlying trait. Maybe we should update the naming there, but honestly feels a bit pedantic. I think the function names here *should* mirror those in the underlying trait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
