alamb commented on code in PR #18839:
URL: https://github.com/apache/datafusion/pull/18839#discussion_r2547246915
##########
datafusion/functions-nested/src/set_ops.rs:
##########
@@ -428,7 +428,7 @@ fn generic_set_lists<OffsetSize: OffsetSizeTrait>(
fn general_set_op(
array1: &ArrayRef,
array2: &ArrayRef,
- set_op: SetOp,
+ set_op: &SetOp,
Review Comment:
I think a better change would be to make `SetOp` implement the `Copy` trait,
as it is an enum with values -- there is no real benefit to passing a reference
https://github.com/apache/datafusion/blob/30b0982f24eef7aa73b088b1e118e6f849f7fcb4/datafusion/functions-nested/src/set_ops.rs#L331-L330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
