Jefffrey commented on code in PR #18839:
URL: https://github.com/apache/datafusion/pull/18839#discussion_r2548275309
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -607,8 +607,8 @@ where
fn string_to_array_inner_3<'a, StringArrType, DelimiterArrType,
StringBuilderType>(
args: &'a [ArrayRef],
- string_array: StringArrType,
- delimiter_array: DelimiterArrType,
+ string_array: &StringArrType,
+ delimiter_array: &DelimiterArrType,
Review Comment:
I still find this especially weird since `StringArrayType<'a>` is
implemented for references, so this becomes a `&&` at the callsite?
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -317,8 +317,8 @@ impl<'a> ArrayWrapper<'a> {
}
}
-fn array_has_dispatch_for_array(
- haystack: ArrayWrapper<'_>,
+fn array_has_dispatch_for_array<'a>(
+ haystack: &ArrayWrapper<'a>,
Review Comment:
This I find a bit interesting considering `ArrayWrapper` is already an enum
over references 🤔
##########
datafusion/functions-nested/src/map.rs:
##########
@@ -126,10 +126,10 @@ fn get_first_array_ref(columnar_value: &ColumnarValue) ->
Result<ArrayRef> {
}
fn make_map_batch_internal(
- keys: ArrayRef,
- values: ArrayRef,
+ keys: &ArrayRef,
+ values: &ArrayRef,
Review Comment:
Are there places where `&dyn Array` might work instead of `&ArrayRef`? Or do
we need to keep the `Arc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
