foskey51 commented on code in PR #18839:
URL: https://github.com/apache/datafusion/pull/18839#discussion_r2550416640
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -607,8 +607,8 @@ where
fn string_to_array_inner_3<'a, StringArrType, DelimiterArrType,
StringBuilderType>(
args: &'a [ArrayRef],
- string_array: StringArrType,
- delimiter_array: DelimiterArrType,
+ string_array: &StringArrType,
+ delimiter_array: &DelimiterArrType,
Review Comment:
But since rust performs de-ref coercion implicitly, so it shouldn't be a
problem. I had the same question initially, but after digging through some
sources, it seems expected behavior.
[1] https://stackoverflow.com/a/28552082
[2] https://users.rust-lang.org/t/double-references-what-they-mean/56668/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
