comphead commented on PR #18841: URL: https://github.com/apache/datafusion/pull/18841#issuecomment-3563775476
> That code path was not touched in this PR at all. Not sure why I should add tests for code that’s not being added or modified. The good practice is to keep test set as complete as possible before refactoring, that was the reason to ask add missing bool tests. I added them in https://github.com/apache/datafusion/pull/18871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
