pepijnve commented on PR #18841: URL: https://github.com/apache/datafusion/pull/18841#issuecomment-3563823434
> The good practice is to keep test set as complete as possible before refactoring I understand what you're saying, but I don't agree with placing that burden on people when making unrelated changes. "You touched a file, so please increase the code coverage for unmodified code paths first" seems a bit contributor hostile. If was changing the boolean code path I would fully agree that you make test first, then refactor, to make sure you're not changing behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
