alamb commented on code in PR #18841:
URL: https://github.com/apache/datafusion/pull/18841#discussion_r2549954770
##########
datafusion/spark/src/function/bitwise/bit_count.rs:
##########
@@ -155,20 +156,6 @@ fn spark_bit_count(value_array: &[ArrayRef]) ->
Result<ArrayRef> {
}
}
Review Comment:
The `popcnt` instruction is crazy fast -- we tested it in one example where
we had a special codepath for no nulls, and I was worried that calculating the
test `if nulls.count_ones() == 0` would overwhelm the improvement
Nowhere close. 🚀
Hackers Delight is a classic -- I am not at all surprised that the Rust
compiler includes all those tricks (and then some!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
