andygrove commented on code in PR #2812:
URL: https://github.com/apache/datafusion-comet/pull/2812#discussion_r2551145152
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -218,6 +226,23 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
val nativeOp = operator2Proto(cometOp)
CometScanWrapper(nativeOp.get, cometOp)
+ // Handle DataWritingCommandExec specially since it doesn't follow the
standard pattern
+ case exec: DataWritingCommandExec =>
+ CometExecRule.writeExecs.get(classOf[DataWritingCommandExec]) match {
Review Comment:
This logic is a bit funky, but I didn't want to spend too much time on this
for the initial PR. The logic will change once we add support for fully native
inputs (such as `native_datafusion`) anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
