timsaucer opened a new pull request, #18916: URL: https://github.com/apache/datafusion/pull/18916
## Which issue does this PR close? Addresses part of https://github.com/apache/datafusion/issues/18671 but does not close it. ## Rationale for this change This PR exposes the `PhysicalExpr` trait via FFI. This will allow us to remove using protobuf for transferring *physical* expressions across the FFI boundary. We will still use protobuf for the *logical* side. The reason this is important is because it will allow us to eventually remove the `core` crate as described in #18671 but also it will enable keeping `ColumnarValue::Scalar` when using UDFs. This is important for UDF performance. ## What changes are included in this PR? This PR introduces the `FFI_PhysicalExpr` trait and a variety of enums and structs that are needed to be FFI stable in order to implement it. It does _not_ replace the existing usage in the UDFs and other places with the `FFI_PhysicalExpr` yet. That comes in a later PR in order to keep the size of the individual requests to manageable. ## Are these changes tested? Unit tests are included. ## Are there any user-facing changes? Since this is pure addition, no user facing changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
