timsaucer commented on code in PR #18916:
URL: https://github.com/apache/datafusion/pull/18916#discussion_r2557701117
##########
datafusion/ffi/Cargo.toml:
##########
@@ -48,7 +48,10 @@ async-ffi = { version = "0.5.0", features = ["abi_stable"] }
async-trait = { workspace = true }
datafusion = { workspace = true, default-features = false }
datafusion-common = { workspace = true }
+datafusion-expr = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
+datafusion-physical-expr = { workspace = true }
+datafusion-physical-expr-common = { workspace = true }
Review Comment:
In this and the following PRs I am introducing more of these crates, even
when they are re-exported in `datafusion` core crate so that it will have a
smaller PR when we remove the core crate at the end of this work epic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
