alamb commented on code in PR #18647:
URL: https://github.com/apache/datafusion/pull/18647#discussion_r2561209613
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -376,83 +366,51 @@ impl ApproxPercentileAccumulator {
match values.data_type() {
DataType::Float64 => {
let array = downcast_value!(values, Float64Array);
- Ok(array
- .values()
- .iter()
- .filter_map(|v| v.try_as_f64().transpose())
- .collect::<Result<Vec<_>>>()?)
+ Ok(array.values().iter().copied().collect::<Vec<_>>())
}
DataType::Float32 => {
let array = downcast_value!(values, Float32Array);
+ Ok(array.values().iter().map(|v| *v as
f64).collect::<Vec<_>>())
+ }
+ DataType::Float16 => {
+ let array = downcast_value!(values, Float16Array);
Ok(array
.values()
.iter()
- .filter_map(|v| v.try_as_f64().transpose())
- .collect::<Result<Vec<_>>>()?)
+ .map(|v| v.to_f64())
+ .collect::<Vec<_>>())
Review Comment:
I agree this looks much clearer and is now much easier to understand what is
happening (the behavior is the same from what I can see)
##########
datafusion/functions-aggregate/src/approx_median.rs:
##########
@@ -57,20 +59,11 @@ make_udaf_expr_and_func!(
```"#,
standard_argument(name = "expression",)
)]
-#[derive(PartialEq, Eq, Hash)]
+#[derive(Debug, PartialEq, Eq, Hash)]
pub struct ApproxMedian {
signature: Signature,
}
-impl Debug for ApproxMedian {
Review Comment:
seems fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
