Jefffrey commented on code in PR #18647: URL: https://github.com/apache/datafusion/pull/18647#discussion_r2525573065
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -910,6 +910,16 @@ SELECT approx_median(col_f64_nan) FROM median_table ---- NaN +query RT +select approx_median(arrow_cast(col_f32, 'Float16')), arrow_typeof(approx_median(arrow_cast(col_f32, 'Float16'))) from median_table; +---- +2.75 Float16 + +query ?T +select approx_median(NULL), arrow_typeof(approx_median(NULL)) from median_table; +---- +NULL Null + Review Comment: I haven't actually fixed the signature for `approx_percentile_cont` yet so this will fail; I might add in a followup PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
