alamb commented on code in PR #18627:
URL: https://github.com/apache/datafusion/pull/18627#discussion_r2561444649


##########
datafusion/sqllogictest/test_files/math.slt:
##########
@@ -713,9 +713,7 @@ EXPLAIN SELECT log(NULL, c2) from aggregate_simple;
 logical_plan
 01)Projection: Float64(NULL) AS log(NULL,aggregate_simple.c2)
 02)--TableScan: aggregate_simple projection=[]
-physical_plan
-01)ProjectionExec: expr=[NULL as log(NULL,aggregate_simple.c2)]
-02)--DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/core/tests/data/aggregate_simple.csv]]}, 
file_type=csv, has_header=true
+physical_plan DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/core/tests/data/aggregate_simple.csv]]}, 
projection=[NULL as log(NULL,aggregate_simple.c2)], file_type=csv, 
has_header=true

Review Comment:
   and there you can see the projection expressions moved into DataSourceExec 
per the plan 🚀 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to