adriangb commented on code in PR #18627:
URL: https://github.com/apache/datafusion/pull/18627#discussion_r2562907251
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -656,57 +696,65 @@ impl DataSource for FileScanConfig {
&self,
projection: &[ProjectionExpr],
) -> Result<Option<Arc<dyn DataSource>>> {
- // This process can be moved into CsvExec, but it would be an overlap
of their responsibility.
-
- // Must be all column references, with no table partition columns
(which can not be projected)
- let partitioned_columns_in_proj = projection.iter().any(|proj_expr| {
- proj_expr
- .expr
- .as_any()
- .downcast_ref::<Column>()
- .map(|expr| expr.index() >= self.file_schema().fields().len())
- .unwrap_or(false)
- });
-
- // If there is any non-column or alias-carrier expression, Projection
should not be removed.
- let no_aliases = all_alias_free_columns(projection);
-
- Ok((no_aliases && !partitioned_columns_in_proj).then(|| {
- let file_scan = self.clone();
- let source = Arc::clone(&file_scan.file_source);
- let new_projections = new_projections_for_columns(
- projection,
- &file_scan
- .projection_exprs
- .as_ref()
- .map(|p| p.ordered_column_indices())
- .unwrap_or_else(||
(0..self.file_schema().fields().len()).collect()),
- );
-
- Arc::new(
- FileScanConfigBuilder::from(file_scan)
- // Assign projected statistics to source
- .with_projection_indices(Some(new_projections))
- .with_source(source)
- .build(),
- ) as _
- }))
+ let projection = ProjectionExprs::new(projection.to_vec()); // TODO:
update signature of this method
Review Comment:
I wanted to change the method to take `&ProjectionExprs`. I've now done so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
