gabotechs commented on code in PR #18919:
URL: https://github.com/apache/datafusion/pull/18919#discussion_r2570765336
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -117,6 +118,9 @@ pub enum Partitioning {
/// Allocate rows based on a hash of one of more expressions and the
specified number of
/// partitions
Hash(Vec<Arc<dyn PhysicalExpr>>, usize),
+ /// Partitions that are already organized by disjoint key values for the
provided expressions.
+ /// Rows that have the same values for these expressions are guaranteed to
be in the same partition.
+ KeyPartitioned(Vec<Arc<dyn PhysicalExpr>>, usize),
Review Comment:
My impression over all is that `KeyPartitioned` should not be adding
anything that is not already representable with `Hash`. I was planning on doing
a longer reasoning on this, but @fmonjalet is right on point in his comment
here https://github.com/apache/datafusion/pull/18919#issuecomment-3586757308,
so I'd just +1 his comment, grab some 🍿, and see what comes out of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
