fmonjalet commented on PR #18919: URL: https://github.com/apache/datafusion/pull/18919#issuecomment-3602235353
Thanks again for the thorough response 🙇 > I do think that think that an implementation of checking to see if a plan would benefit from hash repartitioning on a superset would be able to achieve similar results but I think that having a different type of partitioning would be a clearer implementation. I think this is a good summary, and it will be for maintainers to give a more formal answer on what they prefer seeing maintained. Both solutions have different trade offs, I agree that the alternative to `KeyPartitioned` is tricky logic that may add its own dose of complexity. In any case, in the end I think the plan simplifications you are achieving are worth the effort either way! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
