milenkovicm commented on PR #18739: URL: https://github.com/apache/datafusion/pull/18739#issuecomment-3598642281
Actually, I may have few follow up questions, as PR does not have any associated issue nor it has any description or motivation explanation, which I don't think is especially good practice for changing one of the core interfaces: - Why have we introduced `OptimizerContext` when it only wraps `SessionConfig`, what else do we expect to have in `OptimizerContext`? - If changing interface could we just change method parameter and use `SessionConfig` instead of `ConfigOptions`, instead of adding new method and deprecating? Would it be cleaner approach? - Whats the difference between current and previous Extensions ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
