milenkovicm commented on PR #18739: URL: https://github.com/apache/datafusion/pull/18739#issuecomment-3606022225
Thanks for clarification @gabotechs , just few follow up question: 1. Is the physical optimiser rule in the right place for such functionality, or would it break separation of concerns and make optimiser do too many things ? For quite some time optimiser functionality had very stable API, maybe there was a reason why it did not change much for long time. 2. Would you be able to provide more details what do you mean by "more elegant solution", I guess if there is PR description we would be able to understand it from there. Leading to my last question, 3. Was there a genuine need for such a rush that the PR was merged without any associated issue or description? Breaking down the problem into an issue or at least a description usually helps with understanding it better and potentially prevents changes to functionality that already works as you need it to. As mentioned in the discussion about extensions in https://github.com/apache/datafusion/pull/18739#issuecomment-3602611593, maybe it would prevent unnecessary API change? Also it helps others understanding the the problem you have, and maybe come up good suggestions. Please have in mind that there are product using datafusion for very long time with quite big codebases. So far datafusion managed to balance api stability and benefits of breaking the api very well. I believe we as the community should continue to maintain such a high standard in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
