adriangb commented on code in PR #19284:
URL: https://github.com/apache/datafusion/pull/19284#discussion_r2610885301
##########
datafusion/catalog-listing/src/table.rs:
##########
@@ -659,25 +640,17 @@ impl ListingTable {
get_files_with_limit(files, limit,
self.options.collect_stat).await?;
let file_groups =
file_group.split_files(self.options.target_partitions);
- let (mut file_groups, mut stats) = compute_all_files_statistics(
+ let (file_groups, stats) = compute_all_files_statistics(
file_groups,
self.schema(),
self.options.collect_stat,
inexact_stats,
)?;
- let schema_adapter = self.create_schema_adapter();
- let (schema_mapper, _) =
schema_adapter.map_schema(self.file_schema.as_ref())?;
Review Comment:
This was mapping from file schema -> table schema by filling in unknown
stats for partition columns. It did not do any per-file adaptation, it assumes
all files already have the same schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
