martin-g commented on code in PR #19284:
URL: https://github.com/apache/datafusion/pull/19284#discussion_r2612260514
##########
datafusion/datasource/src/mod.rs:
##########
@@ -561,6 +607,71 @@ mod tests {
sut.get_store(url.as_ref()).unwrap();
}
+ #[test]
+ fn test_with_statistics_appends_partition_column_stats() {
+ use crate::PartitionedFile;
+ use datafusion_common::stats::Precision;
+ use datafusion_common::{ColumnStatistics, ScalarValue, Statistics};
+ use object_store::path::Path;
+
+ // Create a PartitionedFile with partition values
+ let mut pf = PartitionedFile::new(
+ Path::from("test.parquet"),
Review Comment:
nit: Path is not really needed here. The `Path` is passed as `Into<String>`
to the constructor of PartitionedFile and then a new Path is created from the
string.
```suggestion
"test.parquet",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
